Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Enhance segment log #36848

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

bigsheeper
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 14, 2024
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 14, 2024
Copy link
Contributor

mergify bot commented Oct 14, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.51%. Comparing base (8905b04) to head (eb89e41).
Report is 19 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36848      +/-   ##
==========================================
+ Coverage   72.47%   72.51%   +0.03%     
==========================================
  Files        1308     1308              
  Lines      155986   156178     +192     
==========================================
+ Hits       113053   113245     +192     
+ Misses      37820    37818       -2     
- Partials     5113     5115       +2     
Files with missing lines Coverage Δ
internal/datacoord/meta.go 89.83% <100.00%> (+0.01%) ⬆️
internal/querynodev2/segments/segment_l0.go 67.50% <100.00%> (+2.63%) ⬆️
internal/querynodev2/services.go 91.52% <100.00%> (ø)

... and 26 files with indirect coverage changes

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 14, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 15, 2024
@czs007
Copy link
Collaborator

czs007 commented Oct 15, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f3b6792 into milvus-io:master Oct 15, 2024
15 of 16 checks passed
sre-ci-robot pushed a commit that referenced this pull request Oct 15, 2024
/kind improvement

pr: #36848

Signed-off-by: bigsheeper <[email protected]>
jaime0815 pushed a commit to jaime0815/milvus that referenced this pull request Oct 17, 2024
/kind improvement

Signed-off-by: bigsheeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants