Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Enhance segment log (#36848) #36849

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

bigsheeper
Copy link
Contributor

/kind improvement

pr: #36848

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/S Denotes a PR that changes 10-29 lines. labels Oct 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (44564f0) to head (70364d9).
Report is 5 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #36849       +/-   ##
===========================================
+ Coverage   71.90%   84.92%   +13.02%     
===========================================
  Files        1064      797      -267     
  Lines      140834   116302    -24532     
===========================================
- Hits       101262    98772     -2490     
+ Misses      35237    13181    -22056     
- Partials     4335     4349       +14     
Files with missing lines Coverage Δ
internal/datacoord/meta.go 89.88% <100.00%> (ø)
internal/querynodev2/segments/segment_l0.go 67.50% <100.00%> (+2.63%) ⬆️
internal/querynodev2/services.go 91.17% <100.00%> (+<0.01%) ⬆️

... and 296 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Oct 15, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 604e346 into milvus-io:2.4 Oct 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants