Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Support db for bulkinsert #37012

Merged
merged 4 commits into from
Oct 25, 2024
Merged

enhance: Support db for bulkinsert #37012

merged 4 commits into from
Oct 25, 2024

Conversation

bigsheeper
Copy link
Contributor

issue: #31273

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/internal-api labels Oct 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 21, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 21, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 21, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Oct 21, 2024
@bigsheeper bigsheeper mentioned this pull request Oct 21, 2024
Merged
@mergify mergify bot added the ci-passed label Oct 21, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.97%. Comparing base (5e1ff96) to head (73c7264).
Report is 28 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37012       +/-   ##
===========================================
+ Coverage   67.33%   79.97%   +12.64%     
===========================================
  Files         282     1313     +1031     
  Lines       27645   184649   +157004     
===========================================
+ Hits        18614   147670   +129056     
- Misses       9031    31839    +22808     
- Partials        0     5140     +5140
Files with missing lines Coverage Δ
internal/datacoord/import_job.go 100.00% <100.00%> (ø)
internal/datacoord/services.go 85.74% <100.00%> (ø)
...nternal/distributed/proxy/httpserver/handler_v2.go 91.67% <100.00%> (ø)
...nternal/distributed/proxy/httpserver/request_v2.go 100.00% <100.00%> (ø)
internal/proxy/impl.go 85.80% <100.00%> (ø)

... and 1208 files with indirect coverage changes

@bigsheeper bigsheeper added this to the 2.5.0 milestone Oct 23, 2024
sre-ci-robot pushed a commit that referenced this pull request Oct 23, 2024
@bigsheeper
enhance: Support db for bulkinsert (#37012) (#37017)
d6adc62 
issue: #31273

pr: #37012

---------

Signed-off-by: bigsheeper <[email protected]>
@czs007
Copy link
Collaborator

czs007 commented Oct 23, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bigsheeper
fix conflicts
73c7264 
Signed-off-by: bigsheeper <[email protected]>
@sre-ci-robot sre-ci-robot removed the lgtm label Oct 23, 2024
@mergify mergify bot removed the ci-passed label Oct 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@bigsheeper
Copy link
Contributor Author

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 24, 2024
@czs007
Copy link
Collaborator

czs007 commented Oct 25, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 6e90f9e into milvus-io:master Oct 25, 2024
17 checks passed
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Nov 4, 2024
@bigsheeper
Revert "enhance: Support db for bulkinsert (milvus-io#37012) (milvus-…
0cbcd0e 
…io#37017)"

This reverts commit d6adc62.
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Nov 4, 2024
@bigsheeper
Revert "enhance: Support db for bulkinsert (milvus-io#37012) (milvus-…
365bf70 
…io#37017)"

This reverts commit d6adc62.

Signed-off-by: bigsheeper <[email protected]>
czs007 pushed a commit that referenced this pull request Nov 4, 2024
@bigsheeper
Revert "enhance: Support db for bulkinsert (#37012) (#37017)" (#37415)
399ae75 
This reverts commit d6adc62.

Signed-off-by: bigsheeper <[email protected]>
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Nov 4, 2024
@bigsheeper
Revert "enhance: Support db for bulkinsert (milvus-io#37012) (milvus-…
5e39b6a 
…io#37017)"

This reverts commit d6adc62.

Signed-off-by: bigsheeper <[email protected]>
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Nov 4, 2024
@bigsheeper
Revert "enhance: Support db for bulkinsert (milvus-io#37012)"
e0e92c4 
This reverts commit 6e90f9e.

Signed-off-by: bigsheeper <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Nov 5, 2024
@bigsheeper
fix: [2.4] Revert "enhance: Support db for bulkinsert (#37012) (#37017)…
3806621 
…" (#37421)

This reverts commit d6adc62.

issue: #31273

pr: #37420

Signed-off-by: bigsheeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@czs007 czs007 Awaiting requested review from czs007

Assignees

@czs007 czs007

Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bigsheeper @czs007 @sre-ci-robot