Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Revert "enhance: Support db for bulkinsert (#37012) (#37017)" #37421

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Nov 4, 2024

This reverts commit d6adc62.

issue: #31273

pr: #37420

@sre-ci-robot sre-ci-robot added area/internal-api size/L Denotes a PR that changes 100-499 lines. labels Nov 4, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 4, 2024
Copy link
Contributor

mergify bot commented Nov 4, 2024

@bigsheeper

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@bigsheeper bigsheeper changed the title [2.4] Revert "enhance: Support db for bulkinsert (#37012) (#37017)" fix: [2.4] Revert "enhance: Support db for bulkinsert (#37012) (#37017)" Nov 4, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.62%. Comparing base (37d691f) to head (5e39b6a).
Report is 10 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datacoord/services.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37421      +/-   ##
==========================================
+ Coverage   79.05%   79.62%   +0.57%     
==========================================
  Files        1061     1069       +8     
  Lines      164564   165621    +1057     
==========================================
+ Hits       130088   131872    +1784     
+ Misses      30108    29384     -724     
+ Partials     4368     4365       -3     
Files with missing lines Coverage Δ
internal/datacoord/import_job.go 100.00% <ø> (ø)
...nternal/distributed/proxy/httpserver/handler_v2.go 91.41% <100.00%> (+0.60%) ⬆️
...nternal/distributed/proxy/httpserver/request_v2.go 100.00% <100.00%> (ø)
internal/proxy/impl.go 85.79% <100.00%> (+4.34%) ⬆️
internal/datacoord/services.go 84.97% <60.00%> (+0.89%) ⬆️

... and 249 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 4, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 5, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3806621 into milvus-io:2.4 Nov 5, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants