-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: The expression supports filling elements through templates #37033
feat: The expression supports filling elements through templates #37033
Conversation
@xiaocai2333 go-sdk check failed, comment |
@xiaocai2333 E2e jenkins job failed, comment |
…emplates (#37058) issue: #36672 master pr: #37033 milvus-proto pr: milvus-io/milvus-proto#332 Signed-off-by: Cai Zhang <[email protected]>
…emplates (milvus-io#37058) issue: milvus-io#36672 master pr: milvus-io#37033 milvus-proto pr: milvus-io/milvus-proto#332 Signed-off-by: Cai Zhang <[email protected]>
8909454
to
06270d9
Compare
@xiaocai2333 E2e jenkins job failed, comment |
@xiaocai2333 go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37033 +/- ##
==========================================
- Coverage 83.11% 80.83% -2.28%
==========================================
Files 1029 1321 +292
Lines 157231 183036 +25805
==========================================
+ Hits 130689 147965 +17276
- Misses 21369 29881 +8512
- Partials 5173 5190 +17
|
… and OR operations (#37217) issue: #36672 master pr: #37033 Signed-off-by: Cai Zhang <[email protected]>
issue: #milvus-io/milvus#36672 milvus-proto: milvus-io/milvus-proto#331 milvus: milvus-io/milvus#37033 Signed-off-by: Cai Zhang <[email protected]>
…emplates (milvus-io#37058) issue: milvus-io#36672 master pr: milvus-io#37033 milvus-proto pr: milvus-io/milvus-proto#332 Signed-off-by: Cai Zhang <[email protected]>
Signed-off-by: Cai Zhang <[email protected]>
06270d9
to
15d2f1d
Compare
@xiaocai2333 go-sdk check failed, comment |
Signed-off-by: Cai Zhang <[email protected]>
…emplates (milvus-io#37058) issue: milvus-io#36672 master pr: milvus-io#37033 milvus-proto pr: milvus-io/milvus-proto#332 Signed-off-by: Cai Zhang <[email protected]>
@xiaocai2333 go-sdk check failed, comment |
rerun go-sdk |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, xiaocai2333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#37280) issue: #36672 master pr: #37033 milvus-proto pr: milvus-io/milvus-proto#332 Signed-off-by: Cai Zhang <[email protected]>
…#2317) issue: #milvus-io/milvus#36672 milvus-proto: milvus-io/milvus-proto#331 milvus: milvus-io/milvus#37033 Signed-off-by: Cai Zhang <[email protected]> Signed-off-by: NamCaoHai <[email protected]>
issue: #36672
The expression supports filling elements through templates, which helps to reduce the overhead of parsing the elements.