-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [cherry-pick]The expression supports filling elements through templates #37058
feat: [cherry-pick]The expression supports filling elements through templates #37058
Conversation
@xiaocai2333 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
@xiaocai2333 E2e jenkins job failed, comment |
can you link the proto changes? |
internal/parser/planparserv2/convert_field_data_to_generic_value.go
Outdated
Show resolved
Hide resolved
internal/parser/planparserv2/convert_field_data_to_generic_value.go
Outdated
Show resolved
Hide resolved
6dbffba
to
3367309
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! comments are not blocking.
internal/parser/planparserv2/convert_field_data_to_generic_value.go
Outdated
Show resolved
Hide resolved
3367309
to
bf87268
Compare
/lgtm |
Signed-off-by: Cai Zhang <[email protected]>
bf87268
to
f33469d
Compare
/lgtm thanks! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, xiaocai2333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…emplates (milvus-io#37058) issue: milvus-io#36672 master pr: milvus-io#37033 milvus-proto pr: milvus-io/milvus-proto#332 Signed-off-by: Cai Zhang <[email protected]>
…emplates (milvus-io#37058) issue: milvus-io#36672 master pr: milvus-io#37033 milvus-proto pr: milvus-io/milvus-proto#332 Signed-off-by: Cai Zhang <[email protected]>
…emplates (milvus-io#37058) issue: milvus-io#36672 master pr: milvus-io#37033 milvus-proto pr: milvus-io/milvus-proto#332 Signed-off-by: Cai Zhang <[email protected]>
issue: #36672
master pr: #37033
milvus-proto pr: milvus-io/milvus-proto#332