-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use max MvccTs for iterator #37247
Conversation
Signed-off-by: Patrick Weizhi Xu <[email protected]>
@PwzXxm E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37247 +/- ##
==========================================
- Coverage 83.15% 80.85% -2.30%
==========================================
Files 1029 1319 +290
Lines 157251 182693 +25442
==========================================
+ Hits 130764 147720 +16956
- Misses 21322 29794 +8472
- Partials 5165 5179 +14
|
/run-cpu-e2e |
@PwzXxm E2e jenkins job failed, comment |
/run-cpu-e2e |
For exact MVCC view in cluster with multiple channels, we need to pass the channel-mvccTs back to SDK. Do it in later PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm as temp solution
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, PwzXxm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #37158 pr: #37247 Signed-off-by: Patrick Weizhi Xu <[email protected]> (cherry picked from commit 5ed7230)
issue: #37158