Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cp][2.5] use max MvccTs for iterator #37248

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

PwzXxm
Copy link
Contributor

@PwzXxm PwzXxm commented Oct 29, 2024

issue: #37158
pr: #37247

Signed-off-by: Patrick Weizhi Xu [email protected]
(cherry picked from commit 5ed7230)

Signed-off-by: Patrick Weizhi Xu <[email protected]>
(cherry picked from commit 5ed7230)
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 29, 2024
Copy link
Contributor

mergify bot commented Oct 29, 2024

@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 29, 2024

@PwzXxm go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.86%. Comparing base (65c2520) to head (a6b76ff).
Report is 11 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/proxy/util.go 54.54% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37248      +/-   ##
==========================================
- Coverage   83.12%   80.86%   -2.27%     
==========================================
  Files        1028     1318     +290     
  Lines      157213   182689   +25476     
==========================================
+ Hits       130691   147729   +17038     
- Misses      21351    29784    +8433     
- Partials     5171     5176       +5     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 66.91% <0.00%> (∅)
Go 83.14% <46.15%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/task_query.go 80.71% <100.00%> (ø)
internal/proxy/task_search.go 75.95% <100.00%> (ø)
internal/proxy/util.go 89.77% <54.54%> (-0.26%) ⬇️

... and 316 files with indirect coverage changes

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Oct 29, 2024

/run-cpu-e2e

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Oct 29, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Oct 29, 2024

@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Oct 29, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 29, 2024

@PwzXxm go-sdk check failed, comment rerun go-sdk can trigger the job again.

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Oct 29, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Oct 29, 2024

@PwzXxm go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 29, 2024

@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Oct 29, 2024

/run-cpu-e2e

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Oct 29, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Oct 29, 2024

@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Oct 29, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 29, 2024
@PwzXxm
Copy link
Contributor Author

PwzXxm commented Oct 30, 2024

For exact MVCC view in cluster with multiple channels, we need to pass the channel-mvccTs back to SDK. Do it in later PR.

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as temp solution
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, PwzXxm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit faf53cc into milvus-io:2.5 Oct 30, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants