Unify num_shards and mark shards_num as deprecated #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuanYang-cn
force-pushed
the
unify-num-shards
branch
from
3b0dc2c
to
c96cfe7
Compare
XuanYang-cn
force-pushed
the
unify-num-shards
branch
from
c96cfe7
to
f0f2530
Compare
The user can still use shards_num to create collection. But **num_shards** are the recommanded way to create collection and the only way to get from a collection's property See also: milvus-io/milvus#23853 Signed-off-by: yangxuan <[email protected]>
XuanYang-cn
force-pushed
the
unify-num-shards
branch
from
f0f2530
to
9902427
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longjiquan, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
XuanYang-cn
added a commit
to XuanYang-cn/pymilvus
that referenced
this pull request
May 23, 2023
- Unify num_shards and mark shards_num as deprecated (milvus-io#1412) - adding distance metric selection (milvus-io#1428) - Fix None user/password (milvus-io#1443) - deduce secure from user/pass (milvus-io#1445) - last few fixes (milvus-io#1408) See also: milvus-io/milvus#23853 Co-Authored-by: Filip Haltmayer <[email protected]> Signed-off-by: yangxuan <[email protected]>
XuanYang-cn
added a commit
to XuanYang-cn/pymilvus
that referenced
this pull request
May 23, 2023
- Unify num_shards and mark shards_num as deprecated (milvus-io#1412) - adding distance metric selection (milvus-io#1428) - Fix None user/password (milvus-io#1443) - deduce secure from user/pass (milvus-io#1445) - last few fixes (milvus-io#1408) See also: milvus-io/milvus#23853 Co-Authored-by: Filip Haltmayer <[email protected]> Signed-off-by: yangxuan <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
May 23, 2023
- Unify num_shards and mark shards_num as deprecated (#1412) - adding distance metric selection (#1428) - Fix None user/password (#1443) - deduce secure from user/pass (#1445) - last few fixes (#1408) See also: milvus-io/milvus#23853 Signed-off-by: yangxuan <[email protected]> Co-authored-by: Filip Haltmayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user can still use shards_num to create collection. But shards_num are the recommanded way to create collection and the only way to get from a collection's property
See also: milvus-io/milvus#23853