Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deduce secure from user/pass #1445

Merged
merged 1 commit into from
May 19, 2023

Conversation

filip-halt
Copy link
Contributor

Currently secure is only deduced if a uri is passed in with username/pass. It should deduce in any case where user and password are provided.

Signed-off-by: Filip Haltmayer <[email protected]>
@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filip-halt, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ed6a781 into milvus-io:master May 19, 2023
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request May 23, 2023
- Unify num_shards and mark shards_num as deprecated (milvus-io#1412)
- adding distance metric selection (milvus-io#1428)
- Fix None user/password (milvus-io#1443)
- deduce secure from user/pass (milvus-io#1445)
- last few fixes (milvus-io#1408)

See also: milvus-io/milvus#23853

Co-Authored-by: Filip Haltmayer <[email protected]>
Signed-off-by: yangxuan <[email protected]>
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request May 23, 2023
- Unify num_shards and mark shards_num as deprecated (milvus-io#1412)
- adding distance metric selection (milvus-io#1428)
- Fix None user/password (milvus-io#1443)
- deduce secure from user/pass (milvus-io#1445)
- last few fixes (milvus-io#1408)

See also: milvus-io/milvus#23853

Co-Authored-by: Filip Haltmayer <[email protected]>
Signed-off-by: yangxuan <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request May 23, 2023
- Unify num_shards and mark shards_num as deprecated (#1412)
- adding distance metric selection (#1428)
- Fix None user/password (#1443)
- deduce secure from user/pass (#1445)
- last few fixes (#1408)

See also: milvus-io/milvus#23853

Signed-off-by: yangxuan <[email protected]>
Co-authored-by: Filip Haltmayer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants