Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rule type creation should fail if the entity is not provided #1659

Closed
JAORMX opened this issue Nov 15, 2023 · 0 comments · Fixed by #1662
Closed

rule type creation should fail if the entity is not provided #1659

JAORMX opened this issue Nov 15, 2023 · 0 comments · Fixed by #1662
Labels
bug Something isn't working

Comments

@JAORMX
Copy link
Contributor

JAORMX commented Nov 15, 2023

Describe the issue

We should not allow the creation of a rule type that doesn't have the in_entity setting enabled. Today we do.

To Reproduce

Create a rule type without the in_entity setting.

What version are you using?

main
@JAORMX JAORMX added the bug Something isn't working label Nov 15, 2023
JAORMX added a commit that referenced this issue Nov 15, 2023
@JAORMX
Re-introduce entity validation for rule types
92c7249 
I don't know why I commented that out, but this re-introduces that check.

Closes: #1659
@JAORMX JAORMX mentioned this issue Nov 15, 2023
Merged
jhrozek pushed a commit that referenced this issue Nov 15, 2023
@JAORMX
Re-introduce entity validation for rule types (#1662)
f8d1322 
I don't know why I commented that out, but this re-introduces that check.

Closes: #1659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-introduce entity validation for rule types mindersec/minder
1 participant
@JAORMX