Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce entity validation for rule types #1662

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Re-introduce entity validation for rule types #1662

merged 1 commit into from
Nov 15, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 15, 2023

I don't know why I commented that out, but this re-introduces that check.

Closes: #1659

I don't know why I commented that out, but this re-introduces that check.

Closes: #1659
@rdimitrov
Copy link
Member

Should we add a simple test that ensures that for the future? 😃

@jhrozek jhrozek merged commit f8d1322 into main Nov 15, 2023
13 checks passed
@jhrozek jhrozek deleted the validate-rules branch November 15, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rule type creation should fail if the entity is not provided
3 participants