Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add converter for pull request selector #4027

Closed
eleftherias opened this issue Jul 29, 2024 · 0 comments · Fixed by #4028
Closed

Add converter for pull request selector #4027

eleftherias opened this issue Jul 29, 2024 · 0 comments · Fixed by #4028
Assignees
@eleftherias

Comments

@eleftherias
Copy link
Contributor

With the implementation of selectors, we've introduced converters that convert entities to selector entities.
This is currently implemented for artifacts and repositories. We should also implement a converter for pull requests.

Converters: https://github.com/stacklok/minder/blob/95535e528ad2afef916cb3fc093aefebf96d33b2/internal/providers/selectors/selector_entity.go#L96-L103
@eleftherias eleftherias self-assigned this Jul 29, 2024
eleftherias added a commit to eleftherias/minder that referenced this issue Jul 29, 2024
@eleftherias
Add converter for PR selector
c541789 
Fix mindersec#4027
@eleftherias eleftherias mentioned this issue Jul 29, 2024
Merged
10 tasks
eleftherias added a commit to eleftherias/minder that referenced this issue Jul 29, 2024
@eleftherias
Add converter for PR selector
032d510 
Fix mindersec#4027
@JAORMX JAORMX closed this as completed in 05bc063 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add converter for PR selector eleftherias/minder
1 participant
@eleftherias