Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add converter for PR selector #4028

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

eleftherias
Copy link
Contributor

Summary

Add a converter that converts from a pull request entity to a selector entity.
This also fixed the smoke tests.

Fixes #4027

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner July 29, 2024 09:19
@coveralls
Copy link

coveralls commented Jul 29, 2024

Coverage Status

coverage: 54.627% (-0.01%) from 54.64%
when pulling 032d510 on eleftherias:4027-pr-selector
into 832c599 on stacklok:main.

@JAORMX JAORMX merged commit 05bc063 into mindersec:main Jul 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add converter for pull request selector
3 participants