Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use displayName in detailed profile view CLI #4251

Closed
eleftherias opened this issue Aug 22, 2024 · 0 comments · Fixed by #4363
Closed

Use displayName in detailed profile view CLI #4251

eleftherias opened this issue Aug 22, 2024 · 0 comments · Fixed by #4363
Assignees
@eleftherias

Comments

@eleftherias
Copy link
Contributor

eleftherias commented Aug 22, 2024 •
edited
Loading

Acceptance Criteria

Given a profile in the Minder
when I run minder profile status list --detailed
then I see both the short name and the display name

If a profile does not have a custom name set for the rule, then the rule display name should be used. If neither of those exist, then the rule type name should be used.
@eleftherias eleftherias self-assigned this Aug 23, 2024
eleftherias added a commit to eleftherias/minder that referenced this issue Aug 28, 2024
@eleftherias
Add rule display name to profile status table
01f0696 
Also, remove the rule ID from this view to make more room.

Ref mindersec#4251
@eleftherias eleftherias mentioned this issue Aug 28, 2024
Merged
10 tasks
eleftherias added a commit that referenced this issue Aug 28, 2024
@eleftherias
Add rule display name to profile status table (#4300)
3990cb0 
Also, remove the rule ID from this view to make more room.

Ref #4251
eleftherias added a commit to eleftherias/minder that referenced this issue Sep 4, 2024
@eleftherias
Use rule display name as profile rule name default
9626206 
If a profile does not have a custom name set for the rule, then the rule display name should be used as a default.

Fix mindersec#4251
@eleftherias eleftherias mentioned this issue Sep 4, 2024
Merged
10 tasks
eleftherias added a commit to eleftherias/minder that referenced this issue Sep 9, 2024
@eleftherias
Use rule display name as profile rule name default
a877ba1 
If a profile does not have a custom name set for the rule, then the rule display name should be used as a default.

Fix mindersec#4251
eleftherias added a commit to eleftherias/minder that referenced this issue Sep 10, 2024
@eleftherias
Use rule display name as profile rule name default
d702496 
If a profile does not have a custom name set for the rule, then the rule display name should be used as a default.

Fix mindersec#4251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use rule display name as profile rule name default eleftherias/minder
1 participant
@eleftherias