Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule display name to profile status table #4300

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Add the rule display name to the detailed profile status table view.
Also, remove the rule ID from this view to make more room.

Ref #4251

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Also, remove the rule ID from this view to make more room.

Ref mindersec#4251
@coveralls
Copy link

Coverage Status

coverage: 53.859% (-0.002%) from 53.861%
when pulling 01f0696 on eleftherias:4251-rule-display-name
into eaef07a on stacklok:main.

@eleftherias eleftherias merged commit 3990cb0 into mindersec:main Aug 28, 2024
22 checks passed
@eleftherias eleftherias deleted the 4251-rule-display-name branch August 28, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants