Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass configuration when enrolling a provider with a token #3388

Merged
merged 2 commits into from
May 21, 2024
Merged

Pass configuration when enrolling a provider with a token #3388

merged 2 commits into from
May 21, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented May 21, 2024

Summary

Allows to enroll providers and pass a config at the same time.

For example:

echo '{"github": {"one": 1}}' | ./bin/minder provider enroll -c github -n my-little-github -o jakubtestorg -t ghp_secret --config - --yes

Fixes: #3387

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

see above

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek
Use providerClass, not provider name when validating token
e63703a 
This will make reusing the method later easier across providers as well
as allows us to enroll providers whose name is not github and verify
their tokens.
@jhrozek
Enroll providers with token and config
8c0cb28 
This allows to enroll providers and pass a config at the same time.

For example:
```
echo '{"github": {"one": 1}}' | ./bin/minder provider enroll -c github -n my-little-github -o jakubtestorg -t ghp_secret --config - --yes
```
@jhrozek jhrozek requested a review from a team as a code owner May 21, 2024 12:47
@coveralls
Copy link

Coverage Status

coverage: 51.859% (-0.008%) from 51.867%
when pulling 8c0cb28 on jhrozek:enroll_with_token
into 99f8dbe on stacklok:main.

@jhrozek jhrozek merged commit b4ef6ec into mindersec:main May 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend the enroll CLI to pass config when enrolling with a token
3 participants
@jhrozek @coveralls @JAORMX