Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass configuration when enrolling a provider with a token #3388

Merged
merged 2 commits into from
May 21, 2024
Merged

Pass configuration when enrolling a provider with a token #3388

merged 2 commits into from
May 21, 2024

Commits on May 21, 2024

  1. Use providerClass, not provider name when validating token 

    This will make reusing the method later easier across providers as well
as allows us to enroll providers whose name is not github and verify
their tokens.
    @jhrozek
    jhrozek committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e63703a View commit details
    Browse the repository at this point in the history

  2. Enroll providers with token and config 

    This allows to enroll providers and pass a config at the same time.

For example:
```
echo '{"github": {"one": 1}}' | ./bin/minder provider enroll -c github -n my-little-github -o jakubtestorg -t ghp_secret --config - --yes
```
    @jhrozek
    jhrozek committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8c0cb28 View commit details
    Browse the repository at this point in the history