Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added minder provider update CLI command. #3676

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Added minder provider update CLI command. #3676

merged 2 commits into from
Jun 20, 2024

Commits on Jun 20, 2024

  1. Added minder provider update CLI command. 

    Update command allows changing configuration for provider on a
per-field basis. It operates on a read-modify-write fashion,
retrieving current configuration from the backend for modification.

Modification is done by reflection by walking over the struct's JSON
tags. Implementation is recursive, but the maximum depth is determined
by the deepest field in the configuration struct.

Argument parsing is trivial and assumes that arguments are either of
the form `field1.field2.field3` (for `--unset-attribute`) or
field1.field2.field3=value` (for `--set-attribute`). The right parser
for `value` is determined once the correct struct field is found.

It is not currently possible to modify `"github-app"` or `"github"`
fields.

Fixes #3509
    @blkt
    blkt committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7e374e9 View commit details
    Browse the repository at this point in the history

  2. Name flag is mandatory for minder provider update. 

    The command minder provider update operates on a per-provider basis,
which requires the name to be mandatory.
    @blkt
    blkt committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    103448c View commit details
    Browse the repository at this point in the history