Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert profile/rule status queries to use evaluation history table #4195

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

rdimitrov
Copy link
Member

Summary

There seem to be issues with one of the mentioned PRs below so the following PR reverts these changes:

The result of these reverts is confirmed to work okay by a local run of the smoke tests.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner August 19, 2024 08:36
Comment on lines -70 to -72

# Offline tokens from minder CLI
offline.token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was included in one of those commits being reverted. That particular one can probably be re-introduced in another PR.

@coveralls
Copy link

coveralls commented Aug 19, 2024

Coverage Status

coverage: 53.939% (-0.006%) from 53.945%
when pulling 947d6c4 on reverts
into 3835934 on main.

@JAORMX JAORMX merged commit 4cebc27 into main Aug 19, 2024
21 checks passed
@JAORMX JAORMX deleted the reverts branch August 19, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants