Fix issue with Alert URLs for pull requests and artifacts #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `GetProfileStatusByName` URL returns a bunch of information about profiles, including the URL of GHSA alerts if one was created. Minder does not store this URL in the DB, and instead creates it on the fly in the handler code. This assumed that the repo name and owner was returned from the `ListRuleEvaluationsByProfileId` SQL query for all entities, not just repositories. Since my recent changes removed the link between evaluation history and repositories for artifacts and pull requests, this logic stopped working. This works around the problem by querying the DB explicitly. Ideally, the URL would be stored in the database as part of the alert metadata. This handles, for example, self-hosted Github, or indeed, alerts other than GHSAs. I consider that a longer term change which requires additional changes. This fixes the immediate problem.
rdimitrov
approved these changes
Aug 16, 2024
rdimitrov
added a commit
that referenced
this pull request
Aug 19, 2024
)" This reverts commit f5bd045.
10 tasks
JAORMX
pushed a commit
that referenced
this pull request
Aug 19, 2024
…4195) * Revert "Fix issue with Alert URLs for pull requests and artifacts (#4183)" This reverts commit f5bd045. * Revert "Check for non-empty length of previous metadata (#4182)" This reverts commit 2fddec5. * Revert "Change profile/rule status queries to use evaluation history table (#4089)" This reverts commit 2137ce8.
dmjb
added a commit
that referenced
this pull request
Aug 19, 2024
dmjb
added a commit
that referenced
this pull request
Aug 19, 2024
Out of the three commits which were reverted, one of them was replaced by #4197 which solves the problem at source. This will reapply the other two. Some changes were made to fit with the changes introduced by #4197 Validated against smoke tests by @rdimitrov. I also ran the failing smoke tests against this branch locally. * Change profile/rule status queries to use evaluation history table (#4089) This change allows most of the functionality which previously used the `rule_evaluations` (and related) tables to use the new evaluation history tables instead. * Fix issue with Alert URLs for pull requests and artifacts (#4183)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetProfileStatusByNameURL returns a bunch of information about profiles, including the URL of GHSA alerts if one was created. Minder does not store this URL in the DB, and instead creates it on the fly in the handler code. This assumed that the repo name and owner was returned from theListRuleEvaluationsByProfileIdSQL query for all entities, not just repositories.Since my recent changes removed the link between evaluation history and repositories for artifacts and pull requests, this logic stopped working. This works around the problem by querying the DB explicitly.
Ideally, the URL would be stored in the database as part of the alert metadata. This handles, for example, self-hosted Github, or indeed, alerts other than GHSAs. I consider that a longer term change which requires additional changes. This fixes the immediate problem.
Validated locally that this fixes the issue with the smoke tests.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: