-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minio-js takes 15minutes to complete #163
Comments
even after completion, some tests seem not run or missing in the logs, I get only these logs
|
Issue is not reproducible in the latest Mint image:
|
@kannappanr @harshavardhana can we close this issue? |
We can close as not reproducible anymore.. |
Not reproducible will reopen if seen again. |
This issue can be observed again on |
mocha version 4.0.1 seems to make the test hang. Modifying package.json to include mocha 3.5.0 instead of the latest which is 4.0.1 |
Mocha version 4.0.1 seems to hang our functional tests. Package.json is being modified to install 3.5.0, which does not hang functional tests. Fixes minio#163
Is there a relevant bug upstream? |
Mocha version 4.0.1 seems to hang our functional tests. Package.json is being modified to install 3.5.0, which does not hang functional tests. Fixes minio#163
Found this behavior by accident. Just did more tests and found that it works till mocha 3.5.3. It fails on 4.0.0 (released 8 days ago) and 4.0.1 (released 5 days ago). Need to dig more, because this is a combination of minio-js and the recent mocha versions. I haven't looked into issues filed against mocha, if that is what you ask. |
Found this in mocha's release note
So, I am going to revert the change in the PR and add --exit flag to the script that runs the functional test. |
Mocha version 4.0.0 and above seems to hang functional tests if --exit flag is not passed. Added --exit flag to where mocha is being executed in run.sh Fixes minio#163
Added --exit flag to mocha in run.sh Fixes #163
The text was updated successfully, but these errors were encountered: