Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocha version 4.0.0 requires explicit flag to exit tests #184

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

kannappanr
Copy link
Collaborator

@kannappanr kannappanr commented Oct 10, 2017

Mocha version 4.0.0 and above seems to hang functional tests
if --exit flag is not passed.

Added --exit flag to where mocha is being executed in run.sh

Fixes #163

Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - looks good.

Mocha version 4.0.0 and above seems to hang functional tests
if --exit flag is not passed.

Added --exit flag to where mocha is being executed in run.sh

Fixes minio#163
@kannappanr kannappanr changed the title Installing known working version of Mocha to fix the delay issue Mocha version 4.0.0 requires explicit flag to exit tests Oct 11, 2017
Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@nitisht nitisht merged commit 510ae83 into minio:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants