cstruct 6.0.0 compatibility #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is green, anyone happy to review & release //cc @mirage/core |
samoht
reviewed
Mar 31, 2022
| @@ -7,7 +7,7 @@ homepage: "https://github.com/mirage/mirage-channel" | |||
| doc: "http://mirage.github.io/mirage-channel/" | |||
| bug-reports: "https://github.com/mirage/mirage-channel/issues" | |||
| depends: [ | |||
| "ocaml" {>= "4.06.0"} | |||
| "ocaml" {>= "4.07.0"} | |||
There was a problem hiding this comment.
What syntax error do you have (just to keep a record if we see the same message in another context)
There was a problem hiding this comment.
/src: (run (shell "opam exec -- dune build @install @check @runtest && rm -rf _build"))
File "test/test_channel.ml", line 73, characters 4-8:
Error: Syntax error
"/bin/bash" "-c"
"opam exec -- dune build @install @check @runtest && rm -rf _build" failed with exit status 1
The contents of test_channel.ml:
type flow = unit
type error = |
type write_error = Mirage_flow.write_errorI suspect it is the type error = |.
|
LGTM |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Apr 4, 2022
CHANGES: * Add an optional size limit to `read_line` (mirage/mirage-channel#32 @djs55) * Redefine type error as private type of polymorphic variant (mirage/mirage-channel#32 @dinosaure) * Restore compatibility with alcotest 1.4.0 (mirage/mirage-channel#33 @craigfe) * Update to cstruct 6.0.0 API, remove use of deprecated Cstruct.len (mirage/mirage-channel#34 @hannesm)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Apr 4, 2022
CHANGES: * Add an optional size limit to `read_line` (mirage/mirage-channel#32 @djs55) * Redefine type error as private type of polymorphic variant (mirage/mirage-channel#32 @dinosaure) * Restore compatibility with alcotest 1.4.0 (mirage/mirage-channel#33 @craigfe) * Update to cstruct 6.0.0 API, remove use of deprecated Cstruct.len (mirage/mirage-channel#34 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.