Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cstruct 6.0.0 compatibility #34

Merged
merged 3 commits into from
Apr 4, 2022
Merged

cstruct 6.0.0 compatibility #34

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3def8c
update to cstruct 6.0.0
hannesm Mar 31, 2022
43f1ac2
travis is gone
hannesm Mar 31, 2022
54ba9fa
require ocaml 4.07 - otherwise the tests lead to a syntax error
hannesm Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mirage-channel.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ homepage: "https://github.com/mirage/mirage-channel"
doc: "http://mirage.github.io/mirage-channel/"
bug-reports: "https://github.com/mirage/mirage-channel/issues"
depends: [
"ocaml" {>= "4.06.0"}
"ocaml" {>= "4.07.0"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What syntax error do you have (just to keep a record if we see the same message in another context)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/src: (run (shell "opam exec -- dune build @install @check @runtest && rm -rf _build"))
File "test/test_channel.ml", line 73, characters 4-8:
Error: Syntax error
"/bin/bash" "-c"
"opam exec -- dune build @install @check @runtest && rm -rf _build" failed with exit status 1

The contents of test_channel.ml:

    type flow = unit
    type error = |
    type write_error = Mirage_flow.write_error

I suspect it is the type error = |.

"dune" {>= "1.0"}
"mirage-flow" {>= "2.0.0"}
"lwt" {>= "4.0.0"}
Expand Down