-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: impl IdlingRenderScheduler (#10547)
* feat: impl IdleRender * test: pin time on Chromatic * test: pin time on Chromatic * fix: typo * style: rename * style: rename * chore: back to setTimeout * style: linebreak * refactor: remove unused budget option * refactor: use raw unix time * fix: conflict error * fix: floor * fix: subtract * Revert "fix: subtract" This reverts commit 2ef4afa. * Revert "fix: floor" This reverts commit bef8ecd. * Revert "refactor: use raw unix time" This reverts commit 5199e13.
- Loading branch information
1 parent
1eb35dd
commit ee3f408
Showing
7 changed files
with
100 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
packages/frontend/src/components/MkDigitalClock.stories.impl.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* eslint-disable @typescript-eslint/explicit-function-return-type */ | ||
import { StoryObj } from '@storybook/vue3'; | ||
import isChromatic from 'chromatic/isChromatic'; | ||
import MkDigitalClock from './MkDigitalClock.vue'; | ||
export const Default = { | ||
render(args) { | ||
return { | ||
components: { | ||
MkDigitalClock, | ||
}, | ||
setup() { | ||
return { | ||
args, | ||
}; | ||
}, | ||
computed: { | ||
props() { | ||
return { | ||
...this.args, | ||
}; | ||
}, | ||
}, | ||
template: '<MkDigitalClock v-bind="props" />', | ||
}; | ||
}, | ||
args: { | ||
now: isChromatic() ? () => new Date('2023-01-01T10:10:30') : undefined, | ||
}, | ||
parameters: { | ||
layout: 'centered', | ||
}, | ||
} satisfies StoryObj<typeof MkDigitalClock>; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
class IdlingRenderScheduler { | ||
#renderers: Set<FrameRequestCallback>; | ||
#rafId: number; | ||
#ricId: number; | ||
|
||
constructor() { | ||
this.#renderers = new Set(); | ||
this.#rafId = 0; | ||
this.#ricId = requestIdleCallback((deadline) => this.#schedule(deadline)); | ||
} | ||
|
||
#schedule(deadline: IdleDeadline): void { | ||
if (deadline.timeRemaining()) { | ||
this.#rafId = requestAnimationFrame((time) => { | ||
for (const renderer of this.#renderers) { | ||
renderer(time); | ||
} | ||
}); | ||
} | ||
this.#ricId = requestIdleCallback((arg) => this.#schedule(arg)); | ||
} | ||
|
||
add(renderer: FrameRequestCallback): void { | ||
this.#renderers.add(renderer); | ||
} | ||
|
||
delete(renderer: FrameRequestCallback): void { | ||
this.#renderers.delete(renderer); | ||
} | ||
|
||
dispose(): void { | ||
this.#renderers.clear(); | ||
cancelAnimationFrame(this.#rafId); | ||
cancelIdleCallback(this.#ricId); | ||
} | ||
} | ||
|
||
export const defaultIdlingRenderScheduler = new IdlingRenderScheduler(); |