-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl IdlingRenderScheduler #10547
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #10547 +/- ##
============================================
- Coverage 94.71% 78.34% -16.38%
============================================
Files 2 164 +162
Lines 454 20448 +19994
Branches 59 363 +304
============================================
+ Hits 430 16019 +15589
- Misses 24 4429 +4405
... and 161 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
名前がよくないかも(render する renderer をスケジューリングしているのは render ではなさそう) |
} | ||
}); | ||
}); | ||
}, { once: true }); | ||
} else { | ||
sAngle = Math.PI * s / 30; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ、Math.PI * (now.valueOf() / 1000) / 30
にしちゃえばdisableSAnimate
する必要もなくなりそうです
(時間がoverflowすることはないので)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Chromium
- 超速回転する
- Firefox
- 止まる
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
大きすぎて浮動小数点数精度が足りてなさそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
戻した
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Math.PI * Math.floor(new Date().valueOf() / 1000) / 30
は176075836.15642264
辺りでそんなに大きくないので謎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
もしブラウザが内部でラジアンを f32 で扱っていたら 176075836.15642264 から 0.01745329251 (1deg) を引いてもメモリ表現は 0x4d27eb44 から変わらないので、精度が足りていない可能性はやはりありそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
たしかに!
そこを% (60 * 60 * 24 * 365)
とかでどうにかしてもようさそうです(年に一度たけおかしくはなりますが)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
実際性能に影響がどんなにあるのかはわかりませんが問題はなさそうです
} | ||
}); | ||
}); | ||
}, { once: true }); | ||
} else { | ||
sAngle = Math.PI * s / 30; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
たしかに!
そこを% (60 * 60 * 24 * 365)
とかでどうにかしてもようさそうです(年に一度たけおかしくはなりますが)
👍 |
What
より高精度で負荷のかかりづらいレンダリングスケジューラを作る
Why
Close #10510
Additional info (optional)
Checklist