Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does render_stereo work? #32

Closed
koenvaneijk opened this issue Feb 10, 2019 · 3 comments
Closed

Does render_stereo work? #32

koenvaneijk opened this issue Feb 10, 2019 · 3 comments

Comments

@koenvaneijk
Copy link

koenvaneijk commented Feb 10, 2019

I tried setting the arg of render_stereo to 1, however I got an error that two nodes had the same name (camera_left_link). So I went into core.launch and updated the name to camera_right_link. However, then I got the following error:

[ WARN] [1549799539.366419806, 10.066667472]: Could NOT find required uav to camera transform: "uav/camera/center" passed to lookupTransform argument target_frame does not exist. 
[uav/flightgoggles_ros_bridge-7] process has died [pid 17535, exit code 1, cmd /home/koen/catkin_ws/devel/lib/flightgoggles_ros_bridge/ROSClient __name:=flightgoggles_ros_bridge __log:=/home/koen/.ros/log/4b31e4ca-2d2a-11e9-983e-38d5471a2e1e/uav-flightgoggles_ros_bridge-7.log].
log file: /home/koen/.ros/log/4b31e4ca-2d2a-11e9-983e-38d5471a2e1e/uav-flightgoggles_ros_bridge-7*.log

I then went to the contents of ROSClient.cpp and on line 39 I find the following:

//imagePubRight_ = it_.advertiseCamera("/uav/camera/right/image_rect_color", 1);

I tried un-commenting the line above and publishing the contents in the same manner as the left-camera, but with index of 1 (renderOutput.images[1]), however it appears that the rendering engine is not rendering more than one image.

I could deep-dive in the Unity code from an earlier commit (https://github.com/mit-fast/FlightGoggles/tree/042b4a6f5331fa5bf57ec023df530d167226360a/FlightGoggles), however I'm affraid that this might be an older version and incompatible with the current ROSClient.cpp, which might send me even further down the rabbit hole. Even if I would make changes, I understand that I need some copyrighted Unity assets (rendering effects) to rebuild the binary for the simulator.

I tried subscribing to the CompressedImage in /uav/camera/left/image_rect_color/compressedDepth with Python and reading it in an image buffer with OpenCV. but I just get the following output from the image_transport:

Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: bgr8).

My question is:

  • Is there a right camera, or depth image, being rendered by Unity? If so: how can we access it? If not: will it be added?

Looking forward to your help!

Kind regards,
Koen

@Winter-Guerra
Copy link
Contributor

Winter-Guerra commented Feb 10, 2019 via email

@koenvaneijk
Copy link
Author

Hi @Winter-Guerra,

Thank you for your quick reply.

Unfortunate to hear it has been disabled in the 2.0 version of FlightGoggles, we'll have to find a workaround then.

I'll reference this issue from the challenge forum in case anyone else is having the same questions.

Kind regards,
Koen

@varunmurali1
Copy link
Contributor

Closing this issue, please see reply from herox for discussion on the extent of visual processing required.

Winter-Guerra added a commit that referenced this issue Feb 19, 2019
…r (issue #52).

* Makes camera resolution configurable via ROS param files. Alleviates issues from #51 and #32.
* Lowers takeoff thrust threshold to 9.9N (see issues #56, #45).
* Adds Windows64 standalone build to releases page (requested in issues #53, #46).
* Adds nominal gate location file to ROS param server.
* Adds plotter for laser range finder.
* Adds example stereo reconstruction pipeline launch file.

Many thanks to @eatal and @varunmurali1 for their help with this patch!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants