Minor Login Page fixups #3130
Draft
Minor Login Page fixups #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ife6c2be9c90be9481da1ff07773a3b44777cad54
ewpatton
reviewed
Feb 27, 2024
| @@ -20,7 +20,7 @@ | |||
| <!-- Copyright 2007-2009 Google Inc. All Rights Reserved. --> | |||
| <!-- Copyright 2011-2020 Massachusetts Institute of Technology. All Rights Reserved. --> | |||
| <!DOCTYPE html> | |||
| <html> | |||
There was a problem hiding this comment.
I wonder if we should populate lang based on the locale parameter.
ewpatton
reviewed
Feb 27, 2024
| @@ -17,7 +17,7 @@ | |||
| } | |||
|
|
|||
| %> | |||
| <html> | |||
|
@jisqyv I'm trying to work through the PR backlog. There are a few minor things to address here and then we could merge this into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ife6c2be9c90be9481da1ff07773a3b44777cad54