Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Login Page fixups #3130

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appinventor/appengine/war/index.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<!-- Copyright 2007-2009 Google Inc. All Rights Reserved. -->
<!-- Copyright 2011-2020 Massachusetts Institute of Technology. All Rights Reserved. -->
<!DOCTYPE html>
<html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should populate lang based on the locale parameter.

<html lang="en">
<head>
<meta http-equiv="X-UA-Compatible" content="IE=10">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
Expand Down
17 changes: 12 additions & 5 deletions appinventor/appengine/war/login.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
}

%>
<html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

<html lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
<meta HTTP-EQUIV="pragma" CONTENT="no-cache"/>
Expand All @@ -34,9 +34,16 @@ out.println("<center><font color=red><b>" + error + "</b></font></center><br/>")
} %>
<form method=POST action="/login">
<center><table>
<tr><td>${emailAddressLabel}</td><td><input type=text name=email value="" size="35"></td></tr>
<tr><td></td></td>
<tr><td>${passwordLabel}</td><td><input type=password name=password value="" size="35"></td></tr>
<tr><td><label for="email">${emailAddressLabel}</label></td><td>
<input type=text id="email" name=email value="" size="35">
</td>
</tr>
<tr><td></td></tr>
<tr><td><label for="password">${passwordLabel}</label></td>
<td>
<input id="password" type=password name=password value="" size="35">
</td>
</tr>
</table></center>
<% if (locale != null && !locale.equals("")) {
%>
Expand Down Expand Up @@ -108,7 +115,7 @@ out.println("<center><font color=red><b>" + error + "</b></font></center><br/>")

<p style="text-align: center; clear:both;"><a rel="license" href="http://creativecommons.org/licenses/by-sa/3.0/"
target="_blank"><img alt="Creative Commons License" src="/static/images/cc3.png"></a> <br>
<a rel="license" href="http://creativecommons.org/licenses/by-sa/3.0/" target="_blank"></a></p>
<a rel="Creative Commons License" href="http://creativecommons.org/licenses/by-sa/4.0/" target="_blank">Creative Commons License 4.0</a></p>
</footer>
</body></html>