Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate tests #9

Closed
dchud opened this issue Apr 6, 2021 · 2 comments
Closed

Incorporate tests #9

dchud opened this issue Apr 6, 2021 · 2 comments
Assignees

Comments

@dchud
Copy link
Collaborator

dchud commented Apr 6, 2021

@eedrummer had a start on these on the refactor branch. Pull them in and identify more opportunities to test - even if there isn't a good testing story on chart generation.

@dchud
Copy link
Collaborator Author

dchud commented Apr 22, 2021

As part of this, consider consolidating tests under a tests dir and moving the python module files into a growthviz dir. Imports would then need to change accordingly e.g., to from growthviz import sumstats. Probably a good idea given the number of code files we now have.

@dchud
Copy link
Collaborator Author

dchud commented Apr 27, 2021

Per discussion: let's focus this ticket on software-level checks, as opposed to user-supplied data checks. Our main goal with these is to verify that our library functions return as expected with the sample data and perhaps some perturbed/extreme subsets of that sample data.

Please use python's built-in unittest library. Ultimately we should end up with a tests/ directory at the top level, with one or more python test scripts inside that directory that can be called directly or discovered automatically by running python -m unittest at the top level of the package.

Some brief tutorials that might help (let me know if you're looking for more!):

dchud added a commit that referenced this issue Apr 29, 2021
Create unit tests and data checks for adults and some pediatrics, closes #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants