Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unit tests and data checks for adults and some pediatrics #28

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

andersonmeredithk
Copy link
Collaborator

No description provided.

tests/check_data.py Outdated Show resolved Hide resolved
@dchud
Copy link
Collaborator

dchud commented Apr 29, 2021

Please add an empty file under tests called __init__.py. It's a standard-if-weird thing that code directories require for python module loading infrastructure to work correctly. For example:

❯ python -m unittest

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

❯ touch tests/__init__.py

❯ python -m unittest
.........
----------------------------------------------------------------------
Ran 9 tests in 4.786s

OK

❯ ls -l tests/__init__.py
-rw-r--r--  1 dlchudnov  staff  0 Apr 29 12:08 tests/__init__.py

Without the __init__.py file present, the autodiscovery function in the unittest module won't find the test scripts. By creating it, even as an empty file (via touch on macos/unix), it triggers the autodiscovery to look into that directory for tests.

tests/check_data.py Outdated Show resolved Hide resolved
GrowthViz-adults.py Outdated Show resolved Hide resolved
GrowthViz-adults.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dchud dchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes as noted in comments. Otherwise, works for me... glad to see this coming together!

@dchud
Copy link
Collaborator

dchud commented Apr 29, 2021

The tests look good! Found some other issues, but this is good to go.

@dchud dchud merged commit f5ceef7 into develop Apr 29, 2021
@dchud dchud deleted the t9-tests branch April 29, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants