Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gromet] Fix while loop wiring bug #728

Closed
Tracked by #698
vincentraymond-ua opened this issue Dec 12, 2023 · 1 comment · Fixed by #753
Closed
Tracked by #698

[gromet] Fix while loop wiring bug #728

vincentraymond-ua opened this issue Dec 12, 2023 · 1 comment · Fixed by #753
Assignees
@titomeister
Labels
high priority
Milestone
[DARPA] Milestone 11

Comments

@vincentraymond-ua
Copy link
Contributor

vincentraymond-ua commented Dec 12, 2023 •
edited
Loading

When the expression of a while loop is a function call, the pipeline fails to produce Gromet.

def return_true():
    return True

while(return_true()):
    print("TEST")
@vincentraymond-ua vincentraymond-ua mentioned this issue Dec 12, 2023
Closed
@titomeister
Copy link
Contributor

titomeister commented Jan 12, 2024 •
edited
Loading

Jan 12 2024 Update

  • Determined the problem. The Gromet generation was missing a case for appropriately generating the Gromet required for the LiteralValue returns.
  • The case has been added, now making sure everything else with the example is consistent, and making a test for it.
  • Also, another minor issue with some wiring involving returning LiteralValues was discovered, and fixed. Tests for this will also be made.

@titomeister titomeister mentioned this issue Jan 16, 2024
Merged
titomeister added a commit that referenced this issue Jan 18, 2024
@titomeister
Gromet While Loop Wiring Bug PR (#753)
b089c47 
This PR primarily fixes a crash in the Gromet generation when there's a
While loop condition consists only of a function call.
It also fixes another minor wiring bug related to LiteralValues

### Summary of Changes
- Fixed Gromet generation crash for While loop condition of a function
call.
- Fixes a missing wiring bug when a function returns a plain
LiteralValue.
- Adds some small unit tests to maintain consistency.

Resolves #728
github-actions bot added a commit that referenced this issue Jan 18, 2024
@github-actions
Gromet While Loop Wiring Bug PR (#753)
6483c78 
This PR primarily fixes a crash in the Gromet generation when there's a
While loop condition consists only of a function call.
It also fixes another minor wiring bug related to LiteralValues

### Summary of Changes
- Fixed Gromet generation crash for While loop condition of a function
call.
- Fixes a missing wiring bug when a function returns a plain
LiteralValue.
- Adds some small unit tests to maintain consistency.

Resolves #728 b089c47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@titomeister titomeister

Labels
high priority
Projects
None yet
Milestone
[DARPA] Milestone 11
Development

Successfully merging a pull request may close this issue.

Gromet While Loop Wiring Bug PR ml4ai/skema
3 participants
@myedibleenso @titomeister @vincentraymond-ua