Gromet While Loop Wiring Bug PR #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentraymond-ua
approved these changes
Jan 17, 2024
github-actions bot
added a commit
that referenced
this pull request
Jan 18, 2024
This PR primarily fixes a crash in the Gromet generation when there's a While loop condition consists only of a function call. It also fixes another minor wiring bug related to LiteralValues ### Summary of Changes - Fixed Gromet generation crash for While loop condition of a function call. - Fixes a missing wiring bug when a function returns a plain LiteralValue. - Adds some small unit tests to maintain consistency. Resolves #728 b089c47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily fixes a crash in the Gromet generation when there's a While loop condition consists only of a function call.
It also fixes another minor wiring bug related to LiteralValues
Summary of Changes
Resolves #728