Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mne.preprocessing.unify_bad_channels #12014

Merged
merged 45 commits into from
Sep 28, 2023
Merged

Add mne.preprocessing.unify_bad_channels #12014

merged 45 commits into from
Sep 28, 2023

Conversation

anaradanovic
Copy link
Contributor

@anaradanovic anaradanovic commented Sep 25, 2023 •
edited by drammock
Loading

partially addresses #11481

drammock
drammock reviewed Sep 25, 2023
View reviewed changes
mne/preprocessing/unify_bads.py Outdated Show resolved Hide resolved
mne/preprocessing/unify_bads.py Outdated Show resolved Hide resolved
mne/preprocessing/unify_bads.py Outdated Show resolved Hide resolved
mne/preprocessing/unify_bads.py Outdated Show resolved Hide resolved
mne/preprocessing/unify_bads.py Outdated Show resolved Hide resolved
mne/preprocessing/unify_bads.py Outdated Show resolved Hide resolved
anaradanovic and others added 10 commits September 25, 2023 17:13
@anaradanovic @drammock
Update mne/preprocessing/unify_bads.py
0284caa 
Co-authored-by: Daniel McCloy <[email protected]>
@anaradanovic @drammock
Update mne/preprocessing/unify_bads.py
c3e9794 
Co-authored-by: Daniel McCloy <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
aeb7a42 
for more information, see https://pre-commit.ci
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
32f8b35 
for more information, see https://pre-commit.ci
@anaradanovic
updates to inprogress work unify bads
c222956
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0fa5b18 
for more information, see https://pre-commit.ci
@anaradanovic
Move unify_bad_channels function to preprocessing/bads.py
2c200a1
@anaradanovic
add function to namespace
80c329d
@anaradanovic
style fixes
fc91787
@anaradanovic
Merge branch 'unifying_bads' of github.com:anaradanovic/mne-python in…
d77cfc1 
…to unifying_bads
drammock
drammock requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far, see comments below.

mne/preprocessing/__init__.py Outdated Show resolved Hide resolved
mne/preprocessing/bads.py Outdated Show resolved Hide resolved
mne/preprocessing/bads.py Outdated Show resolved Hide resolved
mne/preprocessing/bads.py Outdated Show resolved Hide resolved
mne/preprocessing/bads.py Outdated Show resolved Hide resolved
mne/preprocessing/bads.py Outdated Show resolved Hide resolved
mne/preprocessing/bads.py Outdated Show resolved Hide resolved
mne/preprocessing/bads.py Outdated Show resolved Hide resolved
mne/preprocessing/bads.py Outdated Show resolved Hide resolved
mne/preprocessing/bads.py Outdated Show resolved Hide resolved
drammock
drammock reviewed Sep 27, 2023
View reviewed changes
mne/channels/channels.py Outdated Show resolved Hide resolved
mne/channels/channels.py Outdated Show resolved Hide resolved
mne/preprocessing/bads.py Outdated Show resolved Hide resolved
mne/channels/channels.py Outdated Show resolved Hide resolved
mne/channels/channels.py Outdated Show resolved Hide resolved
mne/channels/channels.py Outdated Show resolved Hide resolved
mne/channels/channels.py Outdated Show resolved Hide resolved
mne/channels/channels.py Outdated Show resolved Hide resolved
mne/channels/channels.py Outdated Show resolved Hide resolved
mne/channels/channels.py Outdated Show resolved Hide resolved
drammock
drammock reviewed Sep 27, 2023
View reviewed changes
mne/channels/channels.py Outdated Show resolved Hide resolved
mne/channels/channels.py Outdated Show resolved Hide resolved
mne/channels/channels.py Outdated Show resolved Hide resolved
mne/channels/channels.py Outdated Show resolved Hide resolved
larsoner
larsoner reviewed Sep 28, 2023
View reviewed changes
mne/channels/channels.py Outdated Show resolved Hide resolved
@drammock
Copy link
Member

nice work @anaradanovic and @nordme! In it goes

@drammock drammock merged commit 9ed326f into mne-tools:main Sep 28, 2023
26 checks passed
@drammock drammock mentioned this pull request Sep 29, 2023
Merged
@larsoner larsoner added the ENH label Oct 2, 2023
@larsoner larsoner changed the title adding unify channels to preprocessing draft Add mne.preprocessing.unify_bad_channels Oct 2, 2023
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
@anaradanovic @pre-commit-ci
@drammock @nordme @larsoner @snwnde
adding unify channels to preprocessing draft (mne-tools#12014)
cd842dc 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Daniel McCloy <[email protected]>
Co-authored-by: nordme <[email protected]>
Co-authored-by: nordme <[email protected]>
Co-authored-by: Eric Larson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner larsoner left review comments

@drammock drammock drammock approved these changes

@mscheltienne mscheltienne Awaiting requested review from mscheltienne mscheltienne is a code owner

@agramfort agramfort Awaiting requested review from agramfort agramfort is a code owner

@cbrnr cbrnr Awaiting requested review from cbrnr

Assignees
No one assigned
Labels
ENH
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anaradanovic @drammock @larsoner @nordme