MAINT: Clean up PyVista contexts #12533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing
git grep FutureWarning
I was struck by how many places we catch potential PyVista warnings. I suspect these are from early days of PyVista so I'm going to remove them and hopefully things are okay. If they're not, hopefully we can use more targeted ignores. If not, then we can at least use awith _pyvista_context()
to DRY the code a bit, and ideally have more targeted use of the context (rather than having tens of lines inside it!).Once we merge this in a follow-up PR I'll add it to
git-blame-revs-ignore
since it's 95% whitespace changes.