explicitly disallow multitaper in presence of bad annotations #12535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12519
For now, with the 1.7 release pending, @larsoner and I agreed that disallowing multitaper on Raws when there are
bad_*
annotations present (andreject_by_annotation=True
) is the best way to go.In the long term, we could make that combination actually work by adding a new param (
chunk_size
or so, analogous ton_per_seg
in Welch) and basically doing a welch-MT combination (using multitaper for each chunk, then combining the estimates from each chunk at the end). It's a bit complicated because (we think) you would need to aggregate across-chunks-within-taper first, and then agg across tapers afterward. (cc @mmagnuski who I think has done that for his research before / maybe even implemented in borsar?)