[Chore] Panel Disable Option #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamhency
suggested changes
Aug 17, 2021
projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.html
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.scss
Show resolved
Hide resolved
grahamhency
suggested changes
Aug 18, 2021
projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.html
Outdated
Show resolved
Hide resolved
grahamhency
suggested changes
Aug 19, 2021
There was a problem hiding this comment.
I just looked at the view (which I should've done the first time around, my bad). I've got a comment on using opacity and also a concern around the hover state of the panel.
If the panel is disabled, I don't think we should apply the hover state. What do you think?
projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.scss
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.scss
Outdated
Show resolved
Hide resolved
grahamhency
suggested changes
Aug 20, 2021
projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.scss
Outdated
Show resolved
Hide resolved
grahamhency
approved these changes
Aug 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Resolves #817
What is the new behavior?
Matches design provided by UX
Does this PR introduce a breaking change?