Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Panel Disable Option #824

Merged
merged 9 commits into from
Aug 20, 2021
Merged

[Chore] Panel Disable Option #824

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4b953c4
add disable option
jiaweicai92 Aug 16, 2021
d3e9a19
add documentation
jiaweicai92 Aug 16, 2021
051ed24
update on feedbacks
jiaweicai92 Aug 17, 2021
a42f4cb
rm trailing whitespace
jiaweicai92 Aug 17, 2021
1244ae9
use ngClass for disabling
jiaweicai92 Aug 18, 2021
c3f3858
update on style for style
jiaweicai92 Aug 19, 2021
310bf04
update code climate
jiaweicai92 Aug 19, 2021
0d333a2
cleanup
jiaweicai92 Aug 19, 2021
1169fdf
update on variable
jiaweicai92 Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<!-- External Link -->
<a
class="go-panel"
[class.go-panel__disabled]="disablePanel"
jiaweicai92 marked this conversation as resolved.
Show resolved Hide resolved
[target]="target ? target : '_blank'"
[rel]="target ? target : 'noreferrer'"
[ngClass]="panelClasses()"
Expand All @@ -17,6 +18,7 @@
<ng-template #noLink>
<button
class="go-panel"
[disabled]="disablePanel"
[ngClass]="panelClasses()"
(click)="handleAction()">
<span class="go-panel__title">
Expand Down
9 changes: 9 additions & 0 deletions projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,11 @@ $base-medium: #767676 !default;
&--header {
color: $base-medium;
}

&__disabled {
opacity: 0.5;
grahamhency marked this conversation as resolved.
Show resolved Hide resolved
pointer-events: none;
}
}

.go-action-sheet {
Expand Down Expand Up @@ -116,4 +121,8 @@ button {
&:focus {
outline: none;
}

&:disabled {
grahamhency marked this conversation as resolved.
Show resolved Hide resolved
opacity: 0.5;
grahamhency marked this conversation as resolved.
Show resolved Hide resolved
}
}
1 change: 1 addition & 0 deletions projects/go-lib/src/lib/components/go-action-sheet/go-panel/go-panel.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export class GoPanelComponent {
@Input() panelContent: string;
@Input() target: string;
@Input() closeOnClick: boolean = true;
@Input() disablePanel: boolean = false;

@Output() action: EventEmitter<void> = new EventEmitter<void>();

Expand Down
8 changes: 8 additions & 0 deletions ...tion-sheet-docs/components/action-sheet-panel-docs/action-sheet-panel-docs.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ <h4 class="go-heading-4">closeOnClick</h4>
</p>
</div>

<div class="go-column go-column--100">
<h4 class="go-heading-4">disablePanel</h4>
<p class="go-body-copy">
This determines whether the panel will be disabled or not.
Defaults to <code class="code-block--inline">false</code>.
</p>
</div>

</div>
</go-card>

Expand Down
1 change: 1 addition & 0 deletions ...action-sheet-docs/components/action-sheet-panel-docs/action-sheet-panel-docs.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export class ActionSheetPanelDocsComponent {
@Input() panelContent: string;
@Input() target: string = '_blank';
@Input() closeOnClick: boolean = true;
@Input() disablePanel: boolean = false;

@Output() action: EventEmitter<void> = new EventEmitter<void>();
`;
Expand Down