Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix_and_chore_changes #882

Closed
wants to merge 1 commit into from

Conversation

adhiyan-tangoe
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Style Update (CSS)
  • Other... Please describe: Chore task

What is the current behavior?

Secondary button, secondary split button and secondary button group were missing its border when in a disabled state.
Resolves 872
Secondary button, secondary split button and secondary button group will have the border : 1px solid #d3d3d3

Form hints does not match the UX approved design
Resolves 870
Form text will be italicized and with size 12px

Error form hints does not match the UX approved design
Resolves 869
Error status size changed from 8px to 9px and use Horizon (#DB3939) for color and hint will be italicized

Does this PR introduce a breaking change?

  • Yes
  • No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Secondary Button Disabled State [Chore] General Form Hint [Chore] Error Form Hints
2 participants