-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes_for_bugfix-872_chore-869-870_task #883
Conversation
projects/go-lib/styles/_hints.scss
Outdated
@@ -33,7 +34,9 @@ | |||
|
|||
&__status { | |||
display: block; | |||
font-size: .5rem; | |||
font-size: 0.5625rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of me feels like having a font-size go 4 digits out is a little overkill... if we need to make it bigger could we make it .56 or .57? Unless there was a specific request/reason for making it .5625, I think 2 digits is more maintainable.
Just realized there is a .5625rem value up above too...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see a requirement to change the size from 8px to 9px, do you think is that okay to keep as .56 which is (8.96px)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saravanan-Tangoe oh I see. If that's the case then I think that's fine, even though it seems weird haha.
@jiaweicai92 what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to 9px instead of 0.5625rem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swimtech20 @Saravanan-Tangoe The change makes sense. 👍 Great job guys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@kpmurphh and myself have no way to provide approval/feedback for this issue. We do not have an instance of goponents on our systems in order to look at the visual fix and we are not in a position to give feedback on coding approaches. Please attach a screenshot of the update or block time on one of our calendars for a review session. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Secondary button, secondary split button and secondary button group were missing its border when in a disabled state.
Resolves 872
Secondary button, secondary split button and secondary button group will have the border : 1px solid #d3d3d3
Form hints does not match the UX approved design
Resolves 870
Form text will be italicized and with size 12px
Error form hints does not match the UX approved design
Resolves 869
Error status size changed from 8px to 9px and use Horizon (#DB3939) for color and hint will be italicized
Does this PR introduce a breaking change?