Only support sim in test_enclave
#163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2022
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
force-pushed
the
feature/fix_urts_package
branch
from
e202602
to
4e9ce96
Compare
Previously the `test_enclave` had a `sim` feature. The `sim` feature was used to build the `test_enclave` in a sim environment. Cargo currently doesn't support feature propagation to _only_ dev dependencies. Always propagating `sim` to the `test_enclave` resulted in failures to package `mc-sgx-urts` as `mc-sgx-urts` was now looking for a published version of `test_enclave`. Now `test_enclave` will only build for the simulation SGX SDK, there is no feature flag to add or remove this.
nick-mobilecoin
force-pushed
the
feature/fix_urts_package
branch
from
4e9ce96
to
9dafcbe
Compare
Codecov Report
@@ Coverage Diff @@
## feature/pre-release-0.2.1 #163 +/- ##
==========================================================
Coverage 84.56% 84.56%
==========================================================
Files 44 44
Lines 2390 2390
==========================================================
Hits 2021 2021
Misses 369 369 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Oct 11, 2022
jcape
approved these changes
Oct 12, 2022
NotGyro
approved these changes
Oct 12, 2022
awygle
approved these changes
Oct 13, 2022
This was referenced Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
test_enclavehad asimfeature. Thesimfeaturewas used to build the
test_enclavein a sim environment. Cargocurrently doesn't support feature propagation to only dev
dependencies. Always propagating
simto thetest_enclaveresulted infailures to package
mc-sgx-urtsasmc-sgx-urtswas now looking for apublished version of
test_enclave. Nowtest_enclavewill only buildfor the simulation SGX SDK, there is no feature flag to add or remove
this.