Add PathInitializer to mc-sgx-dcap-ql
#166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2022
This was referenced Oct 12, 2022
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Oct 12, 2022
nick-mobilecoin
commented
Oct 12, 2022
nick-mobilecoin
commented
Oct 12, 2022
nick-mobilecoin
force-pushed
the
feature/ql_paths_once
branch
from
b028aec
to
ef0e235
Compare
nick-mobilecoin
commented
Oct 12, 2022
nick-mobilecoin
commented
Oct 14, 2022
Codecov Report
@@ Coverage Diff @@
## feature/sealing_parameter_validation #166 +/- ##
========================================================================
+ Coverage 86.67% 87.13% +0.46%
========================================================================
Files 41 41
Lines 2251 2371 +120
========================================================================
+ Hits 1951 2066 +115
- Misses 300 305 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nick-mobilecoin
force-pushed
the
feature/sealing_parameter_validation
branch
from
b001476
to
15b47a1
Compare
nick-mobilecoin
force-pushed
the
feature/ql_paths_once
branch
from
b613e9b
to
d5378aa
Compare
remoun
reviewed
Oct 14, 2022
nick-mobilecoin
force-pushed
the
feature/sealing_parameter_validation
branch
from
15b47a1
to
9cc6746
Compare
nick-mobilecoin
force-pushed
the
feature/ql_paths_once
branch
from
d5378aa
to
3100487
Compare
nick-mobilecoin
force-pushed
the
feature/sealing_parameter_validation
branch
from
9cc6746
to
c89b535
Compare
nick-mobilecoin
force-pushed
the
feature/ql_paths_once
branch
from
3100487
to
b966ca2
Compare
nick-mobilecoin
force-pushed
the
feature/ql_paths_once
branch
from
cc21469
to
8fb5175
Compare
Add a `PathInitializer` struct to `mc-sgx-dcap-ql` to ensure that the necessary DCAP quote library paths are set prior to making quote library calls. As well as ensuring that the paths are only initialized once.
Previously `PATH_INITIALIZER` was a OneCell, this required the use of undefined behavior to sufficiently test. Now `PATH_INITIALIZER` uses a Lazy Mutex which can be consistently reset for testing purposes
Previously `mc-sgx-ql::PathInitializer::with_paths()` used the same generic type for all the pathlike parameters. This had the side effect that all four paths had to be the same type. Now each pathlike parameter has it's own type.
nick-mobilecoin
force-pushed
the
feature/ql_paths_once
branch
from
8fb5175
to
8c9a0b5
Compare
This was referenced Oct 18, 2022
jcape
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
PathInitializerstruct tomc-sgx-dcap-qlto ensure that thenecessary DCAP quote library paths are set prior to making quote library
calls. As well as ensuring that the paths are only initialized once.