Add units to mathematical constants #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
reviewed
Jun 14, 2023
henrikt-ma
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Even though this PR goes beyond only adding unit = "1" (contrary to #4046 (comment)), I am fine with all the changes.
tobolar
changed the title
HansOlsson
added a commit
to HansOlsson/Modelica
that referenced
this pull request
Jun 26, 2023
This corrects an error introduced by modelica#4155
Merged
HansOlsson
added a commit
to HansOlsson/Modelica
that referenced
this pull request
Sep 18, 2023
since it is causing too many regressions for a minor release. With proposed unit-checking in Dymola this reduces the warnings from 2301 to 1224 (Most - but not all are unit-related.) Obviously many of them could be corrected, but I don't see that we have the resources to focus on that for this minor release. The first models found were CompareTransformers, SeriesResonance in Modelica.Electrical.Analog.Examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added units to mathematical constants