-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert adding unit to pi due to regressions #4191
Conversation
since it is causing too many regressions for a minor release. With proposed unit-checking in Dymola this reduces the warnings from 2301 to 1224 (Most - but not all are unit-related.) Obviously many of them could be corrected, but I don't see that we have the resources to focus on that for this minor release. The first models found were CompareTransformers, SeriesResonance in Modelica.Electrical.Analog.Examples.
I would expect there to be a small number of root causes, and that we would have time to correct these before the freeze at the start of the next year. Edit: Based on the affected examples mentioned above, the fix would be a simple matter of introducing parameters with the proper units instead of the literals used in the binding equations involving |
I would strongly recommend to merge this, and then prioritize investigating and fixing the issues together with other items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the units of e, pi and gamma be consistent? It seems arbitrarily otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with it so long as the intent is to resolve the unit issues in the offending models with pi in the future.
@beutlich Regarding the other ones: if those ones aren't problematic today, seems ok to leave to me.
@HansOlsson Is it valuable to add a note/comment in the code that there is an intent to change the unit for pi to 1 in the future? This also might make it feel less arbitrary for somebody who is viewing the code.
I suggest that we get started right away cleaning up the uses of |
As indicated in #4046 it we need to revert part of #4155 since it is causing too many regressions for a minor release.
With proposed unit-checking in Dymola this reduces the warnings from 2301 to 1224 (Most - but not all are unit-related.)
Obviously many of them could be corrected, but I don't see that we have the resources to focus on that for this minor release. The first models found were CompareTransformers, SeriesResonance in Modelica.Electrical.Analog.Examples.