Add comparison signals for DynamicPipeEnergyConservationCheck / DynamicPipeEnergyConservationCheck2 #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ynamicPipeEnergyConservationCheck2
casella
requested review from
maltelenz,
AHaumer,
HansOlsson and
arunkumar-narasimhan
arunkumar-narasimhan
approved these changes
Jun 19, 2024
maltelenz
approved these changes
Jun 19, 2024
HansOlsson
approved these changes
Jun 19, 2024
beutlich
changed the title
beutlich
changed the title
beutlich
changed the title
|
@casella Can this be backported to Maint/4.1.0? |
Esther-Devakirubai
pushed a commit
that referenced
this pull request
Aug 15, 2024
…ynamicPipeEnergyConservationCheck2 (#4425)
|
Backporting this to maintenance branch by #4450 |
beutlich
pushed a commit
that referenced
this pull request
Aug 17, 2024
…ynamicPipeEnergyConservationCheck2 (#4425)
beutlich
added
the
L: ModelicaTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing comparison signals for DynamicPipeEnergyConservationCheck and DynamicPipeEnergyConservationCheck2. Since the goal of the model is to check energy balance by comparing boundary enthalpies, I only added those values to the comparison signals.
Contributes resolving #4349.