feat: Added specific metric for graphite unavailability check result #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-handling
branch
from
026e69a
to
5f0678a
Compare
dmitryanchikov
force-pushed
the
feature/grahpite-unavailability-metric
branch
from
a75c196
to
e4aa229
Compare
Codecov Report
@@ Coverage Diff @@
## feature/graphite-unavailability-handling #766 +/- ##
=========================================================================
Coverage 71.11% 71.11%
=========================================================================
Files 177 177
Lines 9160 9160
=========================================================================
Hits 6514 6514
Misses 2268 2268
Partials 378 378 Continue to review full report at Codecov.
|
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-handling
branch
from
5f0678a
to
c5b979e
Compare
dmitryanchikov
force-pushed
the
feature/grahpite-unavailability-metric
branch
from
e4aa229
to
842d30f
Compare
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-handling
branch
2 times, most recently
from
1383c1b
to
88feba3
Compare
dmitryanchikov
force-pushed
the
feature/grahpite-unavailability-metric
branch
2 times, most recently
from
faca043
to
2d00284
Compare
kissken
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds a new internal Moira metric
moira.checker.remote.unavailablewhich is supposed to show the number of graphite API call failures.