Potential fix Issue 73 + properly override dependency #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PS I'm not very happy of the override of dependency work, I used the getManagementKey but not sure if that's right or if there is a better way - I did not have time to check how maven deals with that. |
|
Would someone be up to fix this PR resolving conflicts and making it run in travis? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just doing a quick PR for first review.
it's a fix for issue #73, on top of that it also will check if the dependency in the profile is a version override.
I'm pretty sure the code does not follow the standard or anything and prob could do with some test for those specific cases. But would like to judge the interest before spending more time on it.