Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix oraclejdk8 problem on Travis #106

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Fix oraclejdk8 problem on Travis #106

merged 1 commit into from
Sep 17, 2019

Conversation

famod
Copy link
Contributor

@famod famod commented Sep 5, 2019 •
edited
Loading

@famod
Copy link
Contributor Author

famod commented Sep 5, 2019

@hohwille This should be merged ASAP so that PRs can be built properly.

Credits to my colleague @tkalmar for finding the solution.

This was referenced Sep 5, 2019
Closed
Open
Closed
Merged
Closed
Merged
Closed
@hohwille hohwille merged commit 1054540 into mojohaus:master Sep 17, 2019
@hohwille
Copy link
Member

Seems my github notifications are going to nirvana. Sorry for the long delay.
We might also want to go to openjdk that has better future in travis?

@famod famod deleted the fix-travis-oraclejdk8 branch September 17, 2019 20:14
@famod
Copy link
Contributor Author

famod commented Sep 17, 2019

We might also want to go to openjdk that has better future in travis?

We should do that. Maybe even a matrix of different JDKs and Maven versions.
But I have to say that I had to jump through hoops to get the most recent minor versions from/on Travis, see: gitflow-incremental-builder/gitflow-incremental-builder@7e344e8#diff-354f30a63fb0907d4ad57269548329e3

You are welcome to reuse this approach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@famod @hohwille