Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Available diagnostics change depending on the what's in the diag_table. #156

Closed
nichannah opened this issue Apr 28, 2015 · 2 comments
Closed

Comments

@nichannah
Copy link
Collaborator

If I run the model with a standard diag_table, then create a new diag_table based on available_diagnostics after that run, then run the model again, the available diagnostics will be different.

This available diagnostics should be a function of the model configuration, not the diagnostics themselves.

@Hallberg-NOAA
Copy link
Collaborator

The available diagnostics file also
  indicates which diagnostics are being used, hence it must be a
  function of the diagnostics themselves.

    - Bob Hallberg

  On 04/28/2015 05:15 PM, Nic Hannah wrote:


  If I run the model with a standard diag_table, then create a
    new diag_table based on available_diagnostics after that run,
    then run the model again, the available diagnostics will be
    different. 
  This available diagnostics should be a function of the model
    configuration, not the diagnostics themselves. 
  —
    Reply to this email directly or view
      it on GitHub.

@nichannah
Copy link
Collaborator Author

OK, my issue description is wrong! The available_diagnostics file was changing but this was actually because of I/O buffering. available_diagnostics was not being closed when the model finished so the contents was variable. Just bad luck that it changed when the diag_table changed! I'll fix this and close the issue as part of #147.

@adcroft adcroft closed this as completed in 568c54c May 1, 2015
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
- 08367b4 Merge branch 'nicjhan-diagnostic-tests' into dev/master
- 958789e Removing latent_evap from list of obsolete diagnostics
- b9a23f4 Revert "Update diagnostic name, old name has been obsoleted. Closes mom-ocean#155"
- 9d03ff3 Merge branch 'diagnostic-tests' of github.com:nicjhan/NOAA-GFDL-MOM6 into nicjhan-diagnostic-tests
- ad474f4 Maximum number of diagnostics increased in order to do exhaustive diagnostic checking. mom-ocean#147.
- 7f5cc91 Update diagnostic name, old name has been obsoleted. Closes mom-ocean#155
- c464f2d Only register N2, S2 diagnostics when the configuration supports them. mom-ocean#147
- b1ae675 Bugfix: Fl_itidal diagnostic shape incorrect. Closes mom-ocean#151
- 568c54c Call diag_mediator_end to close open files. Closes mom-ocean#156
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
- Updates MOM6 to provide sftof.
- Added sftof diagnostic to static sectino of OM4 diag_table
- Closes mom-ocean#156.

- NOAA-GFDL/MOM6@3d60b91 Merge pull request mom-ocean#596 from adcroft/sftof_static_diag
- NOAA-GFDL/MOM6@913e71a Adds static diagnostic sftof
gustavo-marques pushed a commit to gustavo-marques/MOM6 that referenced this issue Aug 11, 2020
Fix multi-restart files in NUOPC cap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants